Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin Rework Search Filter + Bar, Adjust Styles on Header #93

Merged
merged 12 commits into from
Nov 24, 2024

Conversation

banushi-a
Copy link
Contributor

@banushi-a banushi-a commented Nov 16, 2024

Description

Motivation and Context

Closes #[ticket]

Ok so a few things:

  • the API only allows for 1 of term / cycle at a time, so the checkbox will have to wait for the API to be updated to accept a list of possible terms / cycles
  • I didn't make it location bc a dependent ticket is that we have some pre-defined list of acceptable cities / locations. I.e. the location field in the form needs to be a combobox
  • you can't hit enter inside of the select / dropdown so I took the liberty to add a search button
  • The search bar no longer makes sense for the companies page
    • I think we can abstract it so that search-bar is changed to search-bar-roles and then we add a search-bar-companies because having workTerm or cycle doesn't really apply to companies.
    • This also requires us to think about the home page search bar. Right now it's literally just the search bar but I think we can have an option above to search between Roles / Companies and that will be used as a prop for the search-filter component. The search filter then displays the corresponding search-bar based on that prop
    • I want to make a no results found page / component bc it's hard to tell if something is loading or if there are no results so i'm prob gonna do that next

How has this been tested?

Screenshots (if appropriate):

Screenshot 2024-11-16 at 11 32 17 PM Screenshot 2024-11-16 at 11 32 26 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have moved the ticket to "In Review"
  • I have added reviewers to this PR
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 9:23pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cooper-auth ⬜️ Skipped (Inspect) Nov 23, 2024 9:23pm
cooper-docs ⬜️ Skipped (Inspect) Nov 23, 2024 9:23pm

@vercel vercel bot temporarily deployed to Preview – cooper November 16, 2024 04:11 Inactive
@banushi-a banushi-a marked this pull request as ready for review November 16, 2024 04:19
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 17, 2024 04:38 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 17, 2024 04:38 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 17, 2024 04:39 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 17, 2024 04:58 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 17, 2024 04:58 Inactive
@banushi-a banushi-a changed the title [WIP] Begin Rework Search Filter + Bar, Adjust Styles on Header Begin Rework Search Filter + Bar, Adjust Styles on Header Nov 17, 2024
@vercel vercel bot temporarily deployed to Preview – cooper November 17, 2024 04:59 Inactive
@banushi-a banushi-a changed the title Begin Rework Search Filter + Bar, Adjust Styles on Header [WIP] Begin Rework Search Filter + Bar, Adjust Styles on Header Nov 21, 2024
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 23, 2024 03:24 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 23, 2024 03:24 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 23, 2024 03:25 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 23, 2024 04:28 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 23, 2024 04:28 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 23, 2024 04:29 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 23, 2024 04:55 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 23, 2024 04:55 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 23, 2024 04:56 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 23, 2024 06:18 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 23, 2024 06:18 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 23, 2024 06:19 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 23, 2024 21:22 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 23, 2024 21:22 Inactive
@banushi-a banushi-a changed the title [WIP] Begin Rework Search Filter + Bar, Adjust Styles on Header Begin Rework Search Filter + Bar, Adjust Styles on Header Nov 23, 2024
@vercel vercel bot temporarily deployed to Preview – cooper November 23, 2024 21:23 Inactive
Copy link
Collaborator

@joshw2048 joshw2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good come to showcase

Copy link
Collaborator

@RishikeshNK RishikeshNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! feel free to merge if we need those states

const form = useFormContext();

const [selectedCycle, setSelectedCycle] = useState<string | undefined>(cycle);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:susge do we need these states if we set the value in the form?

@banushi-a banushi-a merged commit 1b42a44 into main Nov 24, 2024
8 checks passed
@banushi-a banushi-a deleted the UpdateSearchBar branch November 24, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants